[Gravity/Sphere/Vortex] Fixes for PHP 7.2.
Review Request #537 — Created Dec. 12, 2017 and submitted — Latest diff uploaded
| Information | |
|---|---|
| pprkut | |
| Lunr | |
| 2cbb149... | |
| Reviewers | |
| lunr | |
Apparently, PHP 5.6 not having TypeError is not a problem, since the respective code is never executed. No clue what the deal with empty() not working for $this->configuration['db']['ro_host'] is. For some reason empty() makes it return NULL.
Unit tests on 7.2 and 5.6
| src/Lunr/Gravity/Database/MySQL/MySQLConnection.php |
|---|
| src/Lunr/Gravity/Database/Tests/Helpers/DatabaseAccessObjectQueryTestTrait.php |
|---|
| src/Lunr/Gravity/Filesystem/PhysicalFilesystemAccessObject.php |
|---|
| src/Lunr/Sphere/Tests/SessionBaseTest.php |
|---|
| src/Lunr/Vortex/PAP/Tests/PAPResponseSuccessTest.php |
|---|