[Lunr] General: Fixes for PHP7.1

Review Request #532 — Created Sept. 20, 2017 and submitted

smillernl
Lunr
sean/php71
531
533
b734c96...
lunr
General: Fixes for PHP7.1


  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
There are no open issues
pprkut
  1. 
      
  2. composer.json (Diff revision 1)
     
     
    The issue has been resolved. Show all issues

    to support php 5.6 and 7.1 you can't do either of those, since runkit doesn't work on php 7, and uopz 5 doesn't work on php 5

  3. src/Lunr/Sphere/Tests/SessionTest.php (Diff revision 1)
     
     
     
     
     
    The issue has been resolved. Show all issues

    I don't see anything in the php documentation that would indicate a requirement to use global variables here. "use" declares that $id is inherited from parent scope, which is the scope the function was defined in, and that's definitely the case here.

    1. Me neither, but it doesn't work any other way than global :(

  4. tests/test.bootstrap.inc.php (Diff revision 1)
     
     
     
     
     
    The issue has been resolved. Show all issues
    This probably depends on the current working dir from which the main script runs. Better to incorporate __DIR__ here.
  5. 
      
smillernl
smillernl
smillernl
pprkut
  1. 
      
  2. src/Lunr/Sphere/Tests/SessionTest.php (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been dropped. Show all issues

    if $this->id is never read, why do you need to write to it?

  3. 
      
smillernl
tardypad
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...