Cache: controller

Review Request #527 — Created Aug. 14, 2017 and discarded

p.valk
Lunr
lunr

just for review



  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
This is too complicated to not be centralized. If we need this anywhere else we need to do all of ... pprkut pprkut
Too general. TTL is content specific. pprkut pprkut
pprkut
  1. 
      
  2. src/Lunr/Corona/Controller.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This is too complicated to not be centralized. If we need this anywhere else we need to do all of this again.

    The code that interfaces with the cache shouldn't have to do more than

    $cache->set('key', 'value');
    $cache->set('key', 'value', 'ttl');
    $cache->get('key');
    

    It also most definitely should not have anything to do with the Response class.

  3. src/Lunr/Corona/Controller.php (Diff revision 1)
     
     

    Too general. TTL is content specific.

  4. 
      
p.valk
Review request changed

Status: Discarded

Loading...