[General] Fixes for PHP7

Review Request #526 — Created Aug. 7, 2017 and submitted

Information
smillernl
Lunr
master
525
b4d90fc...
Reviewers
lunr 
General: Fixes for PHP7




 













 

 






 
 
 

  

   
  

  
    
   
  • 
    
    0
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    2
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    2
   
    • 
  

 

 

  

   
    

     Description
     From
     Last Updated
    

   
   


    


    

   
  

 












  

 








 














 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Sphere/Tests/SessionTest.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    that doesn't work with 'use'?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      didn't try that one yet. Maybe
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      No, it can't. That'd give the same effect as static (only working for the first run of the function)
      
I could maybe make it use a class variable and set that every time, but that's way more errorprone iyam.
      
 
      

      3. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      tests/test.bootstrap.inc.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    shouldn't this be guarded by a versioned check?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I can define it as true for php7+
      
 
      

      2. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 















 



 

  

   




smillernl




   

   

  

 



 















 





 

  

   




tardypad




   

   







  

 



 

  


   

   

    
 
tardypad


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




pprkut




   

   





  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    There were 28 failures:

1) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testSQLite3Passed
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

2) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testDatabaseIsSetCorrectly
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

3) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testGetNewDMLQueryBuilderObjectReturnsObject
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

4) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testGetQueryEscaperObjectReturnsObject
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

5) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testGetQueryEscaperObjectCachesObject
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

6) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionBaseTest::testGetQueryEscaperObjectReturnsCachedObject
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

7) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionSetTest::testSetConfigurationSetsDatabaseCorrectly
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

8) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionSetTest::testSetConfigurationDoesNotSetDatabase
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

9) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testSuccessfulConnectReadonly
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

10) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testSuccessfulConnectReadwrite
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

11) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testFailedConnect
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

12) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testConnectDoesNotReconnectWhenAlreadyConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

13) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testConnectFailsWhenDriverIsNotSQLite3
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

14) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testDisconnectDoesNotTryToDisconnectWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

15) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testDisconnect
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

16) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testChangeDatabaseReturnsTrueWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

17) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionConnectTest::testChangeDatabaseReturnsFalseWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

18) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionEscapeTest::testEscapeString with data set #0 ('Start', 'Start', 'Start')
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

19) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testBeginTransactionStartsTransactionWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

20) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testBeginTransactionDoesNothingWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

21) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testCommitWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

22) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testCommitDoesNothingWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

23) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testRollbackWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

24) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testRollbackDoesNothingWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

25) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testEndTransactionWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

26) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionTransactionTest::testEndTransactionDoesNothingWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

27) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionQueryTest::testQueryReturnsFailedQueryResultWhenNotConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

28) Lunr\Gravity\Database\SQLite3\Tests\SQLite3ConnectionQueryTest::testQueryReturnsQueryResultWhenConnected
Expectation failed for method name is equal to <string:offsetExists> when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I didn't touch SQLite3, are you sure these are succeeding on master?
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 















 



 

  

   




smillernl




   

   

  

 



 















 



 

  

   




smillernl




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...