- Download Diff

Summary:

[General] Add support for installing dependencies through decomposer

Review Request #522 — Created June 7, 2017 and submitted Aug. 23, 2017, 6:09 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	decomposer
Bugs:
Depends On:
Commit:	ec6f175...
Reviewers
Groups:	lunr
People:

Description

General: Added Decomposer

reviewed at: https://reviews.lunr.nl/r/522/

Testing Done

unittests.

Issues

0
0
8
0
All Issues: 8

Description	From	Last Updated
No. The point of having support for composer is to not require (or suggest) decomposer.	pprkut	June 7, 2017, 12:55 p.m.
Non-functional	pprkut	June 7, 2017, 12:57 p.m.
Non-functional	pprkut	June 7, 2017, 12:57 p.m.
PHP-Resque is missing	pprkut	June 7, 2017, 5 p.m.
That's not how it works.... You do still need to add it to decomposer as well. Also, wrong captilization	pprkut	Aug. 8, 2017, 11:53 a.m.
too old, also it's PSR-0 not PSR-4	pprkut	Aug. 18, 2017, 2:08 p.m.
wrong include	pprkut	Aug. 18, 2017, 2:08 p.m.
This needs to include a "target-dir": "/Credis"	smillernl	Aug. 22, 2017, 9:38 a.m.

Description:

		General: Added Decomposer

~		reviewed at: https://reviews.lunr.nl/r/521/
	~	reviewed at: https://reviews.lunr.nl/r/522/

I'm pretty sure 'ant phpunit' does not pass after installing these deps with decomposer. Try again! ;)

composer.json (Diff revision 1)

Show all issues

No. The point of having support for composer is to not require (or suggest) decomposer.

decomposer.json (Diff revision 1)
Show all issues
```
Non-functional
```
decomposer.json (Diff revision 1)
Show all issues
```
Non-functional
```

Summary:

-	General: Added Decomposer
+	[General]: Added Decomposer

Commit:

-	eff06180a1689a5ee576d42b552e97762592df27
+	58823386a15c80ed1d5d86cafe194d09c4a4b308

Diff:

Revision 2 (+41)

Show changes

	decomposer.json
	tests/test.bootstrap.inc.php

Change Summary:

Fix summary

Summary:

-	[General]: Added Decomposer
+	[General] Add support for installing dependencies through decomposer

tests/test.bootstrap.inc.php (Diff revision 2)
Show all issues
```
PHP-Resque is missing
```

Commit:

-	58823386a15c80ed1d5d86cafe194d09c4a4b308
+	8bf1a051094616bbfd1960bc5e599e77f2b9bc3e

Diff:

Revision 3 (+42)

Show changes

	decomposer.json
	tests/test.bootstrap.inc.php

tests/test.bootstrap.inc.php (Diff revision 3)

Show all issues

That's not how it works....

You do still need to add it to decomposer as well.

Also, wrong captilization

Testing Done:

~		manual.
	~	unittests.

Commit:

-	8bf1a051094616bbfd1960bc5e599e77f2b9bc3e
+	17874b5872d4ca0863af6631c9e5c22f49a329e4

Diff:

Revision 4 (+52)

Show changes

	decomposer.json
	tests/test.bootstrap.inc.php

...............................................W.WW............  63 / 477 ( 13%)
.....PHP Fatal error:  Call to undefined method Mock_ApnsPHP_Push_20c85c5b::add() in /mnt/progs/projects/web/lunr-composer/src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php on line 170
PHP Stack trace:
PHP   1. {main}() /usr/bin/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:583
PHP   3. PHPUnit_TextUI_Command->run() phar:///usr/bin/phpunit/phpunit/TextUI/Command.php:116
PHP   4. PHPUnit_TextUI_TestRunner->doRun() phar:///usr/bin/phpunit/phpunit/TextUI/Command.php:186
PHP   5. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/TextUI/TestRunner.php:517
PHP   6. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
PHP   7. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
PHP   8. PHPUnit_Framework_TestCase->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
PHP   9. PHPUnit_Framework_TestResult->run() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:860
PHP  10. PHPUnit_Framework_TestCase->runBare() phar:///usr/bin/phpunit/phpunit/Framework/TestResult.php:686
PHP  11. PHPUnit_Framework_TestCase->runTest() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:905
PHP  12. ReflectionMethod->invokeArgs() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:1054
PHP  13. Lunr\Vortex\APNS\ApnsPHP\Tests\APNSDispatcherPushTest->testPushReturnsAPNSResponseObject() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:1054
PHP  14. Lunr\Vortex\APNS\ApnsPHP\APNSDispatcher->push() /mnt/progs/projects/web/lunr-composer/src/Lunr/Vortex/APNS/ApnsPHP/Tests/APNSDispatcherPushTest.php:31

Fatal error: Call to undefined method Mock_ApnsPHP_Push_20c85c5b::add() in /mnt/progs/projects/web/lunr-composer/src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php on line 170

Call Stack:
    0.0642     482072   1. {main}() /usr/bin/phpunit:0
    0.1431   15344728   2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:583
    0.1431   15353880   3. PHPUnit_TextUI_Command->run() phar:///usr/bin/phpunit/phpunit/TextUI/Command.php:116
    1.0400   33922424   4. PHPUnit_TextUI_TestRunner->doRun() phar:///usr/bin/phpunit/phpunit/TextUI/Command.php:186
    1.2633   34017072   5. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/TextUI/TestRunner.php:517
    1.3108   34021432   6. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
    3.7584   38271936   7. PHPUnit_Framework_TestSuite->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
    3.7776   38275568   8. PHPUnit_Framework_TestCase->run() phar:///usr/bin/phpunit/phpunit/Framework/TestSuite.php:722
    3.7776   38276152   9. PHPUnit_Framework_TestResult->run() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:860
    3.7795   38279384  10. PHPUnit_Framework_TestCase->runBare() phar:///usr/bin/phpunit/phpunit/Framework/TestResult.php:686
    3.7878   38302704  11. PHPUnit_Framework_TestCase->runTest() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:905
    3.7880   38303568  12. ReflectionMethod->invokeArgs() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:1054
    3.7880   38303664  13. Lunr\Vortex\APNS\ApnsPHP\Tests\APNSDispatcherPushTest->testPushReturnsAPNSResponseObject() phar:///usr/bin/phpunit/phpunit/Framework/TestCase.php:1054
    3.7881   38304328  14. Lunr\Vortex\APNS\ApnsPHP\APNSDispatcher->push() /mnt/progs/projects/web/lunr-composer/src/Lunr/Vortex/APNS/ApnsPHP/Tests/APNSDispatcherPushTest.php:31

decomposer.json (Diff revision 4)

Show all issues

too old, also it's PSR-0 not PSR-4

tests/test.bootstrap.inc.php (Diff revision 4)
Show all issues
```
wrong include
```

Commit:

-	17874b5872d4ca0863af6631c9e5c22f49a329e4
+	8baf4ed04fc815409c9ca5bb780027f961caff99

Diff:

Revision 5 (+58)

Show changes

	decomposer.json
	tests/test.bootstrap.inc.php

decomposer.json (Diff revision 5)
Show all issues
```
This needs to include a "target-dir": "/Credis"
```
1. p.valk Aug. 18, 2017, 5:51 p.m.
  huh? thats only for psr-4
2. smillernl Aug. 18, 2017, 5:58 p.m.
  wrong line

Commit:

-	8baf4ed04fc815409c9ca5bb780027f961caff99
+	ec6f175fd07829e05f7518cdd93263f2d3bd1481

Diff:

Revision 6 (+59)

Show changes

	decomposer.json
	tests/test.bootstrap.inc.php

Ship it!

decomposer.json (Diff revision 6)

We should probably make this rc5 at some point

decomposer.json (Diff revision 6)

We should probably update this to 1.8.2 at some point

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[General] Add support for installing dependencies through decomposer

Description:

Summary:

Commit:

Diff:

Change Summary:

Summary:

Commit:

Diff:

Testing Done:

Commit:

Diff:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: