- Download Diff

Summary:

Vortex: Changed GCMDispatcher for FCM

Review Request #517 — Created April 25, 2017 and submitted May 10, 2017, 2:02 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	vortex-3.6
Bugs:
Depends On:
Blocks:	483
Commit:	0c98fca...
Reviewers
Groups:	lunr
People:

Description

Testing Done

Issues

0
0
4
0
All Issues: 4

Description	From	Last Updated
wouldn't it make more sense to make the 'GCM' part of the message dynamic rather than the entire message?	pprkut	April 25, 2017, 2:26 p.m.
Can we have some better ... text here? 'GCM' is not a message, nor a warning	pprkut	May 3, 2017, 10:20 a.m.
Donaudampfschifffahrtskapitänskajütenwachhundshüttendach	pprkut	May 10, 2017, 9:40 a.m.
why not make this protected as well?	pprkut	May 10, 2017, 11:59 a.m.

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 1)

Show all issues

wouldn't it make more sense to make the 'GCM' part of the message dynamic rather than the entire message?

p.valk April 25, 2017, 2:17 p.m.

well i think that would look more ugly. i think this way the code looks cleaner.

pprkut April 25, 2017, 2:25 p.m.

That may be, but when we want to change the message, we have to hunt down all subclasses.

p.valk April 25, 2017, 2:29 p.m.
```
well thats also true.
```

Branch:

+	vortex-3.6

Commit:

-	2653bbcdb7a12bb023c743b7ccd58259d61b6381
+	3a6911af3087416b0f9bd7bf451c551a218d6e4a

Diff:

Revision 2 (+15 -8)

Show changes

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 2)

Show all issues

Can we have some better ... text here?
'GCM' is not a message, nor a warning

Commit:

-	3a6911af3087416b0f9bd7bf451c551a218d6e4a
+	535dd953e67b246f67adda004c1a27260c660db6

Diff:

Revision 3 (+15 -8)

Show changes

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revisions 2 - 3)
Show all issues
```
Donaudampfschifffahrtskapitänskajütenwachhundshüttendach
```
1. tardypad May 3, 2017, 5:01 p.m.
  putaindemerdedesuffixealacon
2. p.valk May 3, 2017, 5:11 p.m.
  WHAT?!
3. pprkut May 3, 2017, 5:37 p.m.
  Look at the constant name and guess

Commit:

-	535dd953e67b246f67adda004c1a27260c660db6
+	7bc0450cb087da56acef2e97391c112ee147a8c1

Diff:

Revision 4 (+15 -8)

Show changes

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 4)
Show all issues
```
why not make this protected as well?
```

Commit:

-	7bc0450cb087da56acef2e97391c112ee147a8c1
+	0c98fca5aa2817250d684b0cf1f5837bce28b6a2

Diff:

Revision 5 (+16 -9)

Show changes

src/Lunr/Vortex/GCM/GCMDispatcher.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

Vortex: Changed GCMDispatcher for FCM

Branch:

Commit:

Diff:

Commit:

Diff:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: