This change has been marked as submitted.

Describe the submission (optional):

Merged into master

Summary:

Vortex: Changed GCMDispatcher for FCM

Review Request #517 — Created April 25, 2017 and submitted 8 years, 1 month ago

Description

Vortex: Changed GCMDispatcher for FCM

Testing Done

Issues

Description	From	Last Updated
wouldn't it make more sense to make the 'GCM' part of the message dynamic rather than the entire message?	pprkut	8 years, 1 month ago
Can we have some better ... text here? 'GCM' is not a message, nor a warning	pprkut	8 years, 1 month ago
Donaudampfschifffahrtskapitänskajütenwachhundshüttendach	pprkut	8 years, 1 month ago
why not make this protected as well?	pprkut	8 years, 1 month ago
There are no open issues

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 1)

The issue has been resolved. Show all issues

wouldn't it make more sense to make the 'GCM' part of the message dynamic rather than the entire message?

well i think that would look more ugly. i think this way the code looks cleaner.

That may be, but when we want to change the message, we have to hunt down all subclasses.

+	vortex-3.6

-	2653bbcdb7a12bb023c743b7ccd58259d61b6381
+	3a6911af3087416b0f9bd7bf451c551a218d6e4a

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 2)

The issue has been resolved. Show all issues

Can we have some better ... text here?
'GCM' is not a message, nor a warning

-	3a6911af3087416b0f9bd7bf451c551a218d6e4a
+	535dd953e67b246f67adda004c1a27260c660db6