Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

Vortex: Changed GCM for FCM

Review Request #516 — Created April 24, 2017 and submitted April 25, 2017, 4:56 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	vortex-3.5
Bugs:
Depends On:
Blocks:	483
Commit:	d56df52...
Reviewers
Groups:	lunr
People:

Description

Vortex: Changed GCM for FCM

Testing Done

unittests

Issues

0
0
5
0
All Issues: 5

Description	From	Last Updated
please don't mix camelCase and snake_case.	pprkut	April 24, 2017, 2:23 p.m.
ditto	pprkut	April 24, 2017, 2:23 p.m.
right, nice try ;) I think by now you know that all our methods are snake_case, right? :P	pprkut	April 25, 2017, 9:31 a.m.
...	pprkut	April 25, 2017, 11:33 a.m.
good :) Now we need unit tests ;)	pprkut	April 25, 2017, 3:23 p.m.

Testing Done:

+

unittests

Branch:

+	vortex-3.5

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 1)
Show all issues
```
please don't mix camelCase and snake_case.
```
src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 1)
Show all issues
```
ditto
```

Commit:

-	66a9dd1a04a50af0c56707c4d832b9bd2559a58b
+	bdaef6fd019f53d156930972a59bba3f229ace0e

Diff:

Revision 2 (+26 -2)

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 2)

Show all issues

right, nice try ;)

I think by now you know that all our methods are snake_case, right? :P

Commit:

-	bdaef6fd019f53d156930972a59bba3f229ace0e
+	bdde3818511e995f0ed143e014cc82210add2261

Diff:

Revision 3 (+26 -2)

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 3)
Show all issues
```
...
```

Commit:

-	bdde3818511e995f0ed143e014cc82210add2261
+	e670fe148b03dc622a6f1d6fe7d8dff4f38133ae

Diff:

Revision 4 (+26 -2)

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 4)

Show all issues

good :)
Now we need unit tests ;)

Commit:

-	e670fe148b03dc622a6f1d6fe7d8dff4f38133ae
+	d56df52ea166ee5ca25eaedbbea751c2a41e5aa8

Diff:

Revision 5 (+56 -2)

	src/Lunr/Vortex/GCM/GCMDispatcher.php
	src/Lunr/Vortex/GCM/Tests/GCMDispatcherTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...