[Lunr] Core: allow non-string values in the locators

Review Request #514 — Created April 21, 2017 and submitted April 21, 2017, 3:55 p.m.

Description

Core: allow non-string values in the locators

Testing Done

Issues

Description	From	Last Updated
not quite. calling $this->locate() on a value that is not a string doesn't make much sense, so you probably want ...	pprkut	April 21, 2017, 3:37 p.m.

src/Lunr/Core/ConfigServiceLocator.php (Diff revision 1)

Show all issues

not quite.

calling $this->locate() on a value that is not a string doesn't make much sense, so you probably want an early catch for non-string values.

locate has a check for non-string values already. I can double it but doesn't seem useful.

Ship it!

Merged into master

You have a pending review.