[Core] Move to PSR-4 compatible loading of phpunit.

Review Request #500 — Created Feb. 24, 2017 and submitted

smillernl
Lunr
fix/phpunit_update
75a479d...
lunr
Core: Move to PSR-4 compatible loading of phpunit


  • 0
  • 0
  • 1
  • 5
  • 6
Description From Last Updated
There are no open issues
smillernl
tardypad
  1. 
      
  2. The issue has been resolved. Show all issues

    I think this is not really explicit enough anymore
    maybe use an PHPUnitError alias?

  3. The issue has been dropped. Show all issues

    not sure what this is

    1. This is because pre-6.0 doesn't completely let go of the PSR-1 dashes_as_slashes idea. So we need the class name PHPUnit_Framework_Error available as well.

  4. The issue has been dropped. Show all issues

    can this be simpler a PHPUnitWarning alias?

  5. 
      
pprkut
  1. Similar with all the classes this is affecting

    1. All of these would break 5.7.x support, the current method (however unfortunate) ensures 5.7.x and 6.x compatibility with PHPUnit

  2. The issue has been dropped. Show all issues

    if you change this here, wouldn't it make the alias on top unnecessary?

  3. The issue has been dropped. Show all issues

    same here

  4. The issue has been dropped. Show all issues

    same here

  5. 
      
smillernl
pprkut
  1. [exec] There were 5 errors:
    [exec]
    [exec] 1) Lunr\Corona\Tests\FrontControllerDispatchTest::testDispatchWithInvalidControllerValues with data set #0 (null)
    [exec] ReflectionException: Class Error does not exist
    [exec]
    [exec] 2) Lunr\Corona\Tests\FrontControllerDispatchTest::testDispatchWithInvalidControllerValues with data set #1 (false)
    [exec] ReflectionException: Class Error does not exist
    [exec]
    [exec] 3) Lunr\Corona\Tests\FrontControllerDispatchTest::testDispatchWithInvalidControllerValues with data set #2 (1)
    [exec] ReflectionException: Class Error does not exist
    [exec]
    [exec] 4) Lunr\Corona\Tests\FrontControllerDispatchTest::testDispatchWithInvalidControllerValues with data set #3 (1.1000000000000001)
    [exec] ReflectionException: Class Error does not exist
    [exec]
    [exec] 5) Lunr\Corona\Tests\FrontControllerDispatchTest::testDispatchWithInvalidControllerValues with data set #4 ('String')
    [exec] ReflectionException: Class Error does not exist

  2. 
      
smillernl
pprkut
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...