[Corona/Shadow] Add support for easier fetching of the HTTP method of a request

Review Request #487 — Created Jan. 16, 2017 and submitted

Information
pprkut
Lunr
92fa686...
Reviewers
lunr 
Corona: Add support for easier fetching of the HTTP method of a request.

Shadow: Add HTTP method support to cli requests.

Corona: Add HTTP method support to the plain request parser.
Unit tests
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tardypad
tardypad 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Corona/HttpMethod.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Not sure it makes sense to include this 'cacheable' field here.
    
It is really confusing.
    

    If you want to keep it, we should put something different than "yes" for POST and PATCH to indicate that they are cacheable only if the response "includes explicit freshness information"
    

    https://tools.ietf.org/html/rfc7231#section-4.3.3
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I mostly just copied the info from https://en.wikipedia.org/wiki/Hypertext_Transfer_Protocol#Summary_table
      
to have some kind of information on the methods.
      

      I don't mind either way. So drop or improve it?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Doesn't seem really useful to me, so maybe just remove it
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...