[Vortex] FCM Response

Review Request #482 — Created Jan. 3, 2017 and submitted April 24, 2017, 5:37 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	vortex-3
Bugs:
Depends On:	~~481~~
Blocks:	483
Commit:	b337f8c...
Reviewers
Groups:	lunr
People:

Description

Added Response based on GCM

Testing Done

unittests.

Issues

0
0
3
0
All Issues: 3

Description	From	Last Updated
same issue as the payload	smillernl	April 19, 2017, 4:10 p.m.
missing constructor and destructor	pprkut	Feb. 1, 2017, 11:17 a.m.
you're not doing anything with this, so why do you have it?	pprkut	Feb. 1, 2017, 11:14 a.m.

src/Lunr/Vortex/FCM/Tests/FCMResponseAddBatchResponseTest.php (Diff revision 1)

Show all issues

same issue as the payload

p.valk Jan. 31, 2017, 10:27 a.m.

we can use the gcm Response but i think its cleaner to use this. or we should change the name from GCMResponse to something more generic because it will be both gcm and fcm.
i'l delete the tests that are testing the extended class.

Commit:

-	717f377f723a0f8966a87903bc14e3294989f6ca
+	58d61e90b6f5ad0f5e9e5f9ef032ee592f1153cb

Diff:

Revision 2 (+123)

Show changes

	src/Lunr/Vortex/FCM/FCMResponse.php
	src/Lunr/Vortex/FCM/Tests/FCMResponseBaseTest.php
	src/Lunr/Vortex/FCM/Tests/FCMResponseTest.php
	tests/phpunit.xml

Change Summary:

Update summary + description

Summary:

-	[Vortex] added FCM based on GCM
+	[Vortex] FCM Response

Description:

~		Added Response
	~	Added Response based on GCM

src/Lunr/Vortex/FCM/FCMResponse.php (Diff revision 2)
Show all issues
```
missing constructor and destructor
```

src/Lunr/Vortex/FCM/Tests/FCMResponseTest.php (Diff revision 2)

Show all issues

you're not doing anything with this, so why do you have it?

p.valk Feb. 1, 2017, 10:52 a.m.

so the FCMResponseBaseTest and FCMResponseTest doesnt need to be added when there are no tests? i thought maybe for future use or for clean code style.