- Download Diff

Summary:

Gravity: Added maxscale

Review Request #472 — Created Dec. 20, 2016 and submitted Jan. 13, 2017, 2:46 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	ML-423
Bugs:
Depends On:
Commit:	ff04d37...
Reviewers
Groups:	lunr
People:

Description

added maxscale hint style.

Testing Done

unittests.

Issues

0
0
11
0
All Issues: 11

Description	From	Last Updated
NULL is not a good default in this case.	pprkut	Dec. 20, 2016, 1:30 p.m.
I'd rather have this inverted. mysqlnd is only really useful for php <= 5.5, maybe even 5.4.	pprkut	Dec. 20, 2016, 1:30 p.m.
missing break	pprkut	Dec. 20, 2016, 1:30 p.m.
NULL is not a good default in this case	pprkut	Dec. 20, 2016, 1:30 p.m.
missing break	pprkut	Dec. 20, 2016, 1:30 p.m.
style	pprkut	Dec. 22, 2016, 2:07 p.m.
missing default statement	pprkut	Dec. 22, 2016, 2:08 p.m.
style	pprkut	Dec. 22, 2016, 2:07 p.m.
missing default statement	pprkut	Dec. 22, 2016, 2:08 p.m.
style	pprkut	Jan. 3, 2017, 10:46 a.m.
typically the order is exactly the other way around: case mysqlnd case maxscale default	pprkut	Jan. 3, 2017, 10:46 a.m.

Change Summary:

Remove reference to bogus bug

Bugs:

-	ML-423

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 1)
Show all issues
```
NULL is not a good default in this case.
```

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 1)

Show all issues

I'd rather have this inverted. mysqlnd is only really useful for php <= 5.5, maybe even 5.4.

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 1)
Show all issues
```
missing break
```
src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 1)
Show all issues
```
NULL is not a good default in this case
```
src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 1)
Show all issues
```
missing break
```

Commit:

-	2d8cbe27cfb04b2f347df88fb191187c781559a5
+	6278371159a43ee653c165f59d8f6d4b3657f284

Diff:

Revision 2 (+75 -5)

Show changes

	src/Lunr/Gravity/Database/MySQL/MySQLConnection.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionMasterSlaveTest.php

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 2)
Show all issues
```
style
```

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 2)

Show all issues

missing default statement

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 2)
Show all issues
```
style
```
src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 2)
Show all issues
```
missing default statement
```

Commit:

-	6278371159a43ee653c165f59d8f6d4b3657f284
+	f0bcedc7f3b6c4b34a91c2047cce4fc8d8dc4152

Diff:

Revision 3 (+77 -5)

Show changes

	src/Lunr/Gravity/Database/MySQL/MySQLConnection.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionMasterSlaveTest.php

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 3)
Show all issues
```
style
```
1. p.valk Dec. 23, 2016, 3:36 p.m.
  you mean that the text What hint style to use. should be changed too What style to use.?
2. pprkut Dec. 27, 2016, 3:40 p.m.
  I mean coding style

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php (Diff revision 3)

Show all issues

typically the order is exactly the other way around:

case mysqlnd
case maxscale
default

p.valk Dec. 23, 2016, 3:36 p.m.

ok, what about putting the mysqlnd on top, then the default that flows into the maxscale one?
or have default do nothing? or copy the content of maxscale into default?

pprkut Dec. 27, 2016, 3:40 p.m.
```
maxscale should flow into the default
```

Commit:

-	f0bcedc7f3b6c4b34a91c2047cce4fc8d8dc4152
+	ff04d3757a5601f82eba383650e3e3cdacd11489

Diff:

Revision 4 (+79 -5)

Show changes

	src/Lunr/Gravity/Database/MySQL/MySQLConnection.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionMasterSlaveTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

Gravity: Added maxscale

Change Summary:

Bugs:

Commit:

Diff:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: