-
-
src/Lunr/Vortex/Email/EmailDispatcher.php (Diff revision 1) I think we better call this property $mailer in every class
Otherwise, for example later in the EmailResponse class, we end up with confusing parameterspublic function __construct($mail, $logger, $email)
[Vortex] Switch to PHPMailer instead of Lunr's Mail class
Review Request #451 — Created Aug. 17, 2016 and submitted
Information | |
---|---|
pprkut | |
Lunr | |
pprkut:phpmailer | |
Reviewers | |
lunr | |
Switch to PHPMailer instead of Lunr's Mail class.
PHPMailer unfortunately is not reentrant. So in order to keep the thing testable we have to resort to the clone hack.
Unit tests
Change Summary:
Added comment about cloning.
Renamed $mail to $mail_transport