Support: use M2mobi fork of ApnsPHP

Review Request #449 — Created June 17, 2016 and submitted

tardypad
Lunr
setup_m2mobi_apns
lunr

They will probably take some time before merging the PSR-3 changes



  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
tardypad
pprkut
  1. 
      
  2. support/setup.sh (Diff revision 1)
     
     

    are you sure you want v1.0.1 here? That would be the same no matter what fork you picked

  3. 
      
tardypad
pprkut
  1. 
      
  2. support/setup.sh (Diff revision 2)
     
     

    sorry, no.

    "master" is a floating pointer. It doesn't return you a deterministic tarball all the time, which can lead to things breaking without anyone knowing why.

    This download needs to point to something that doesn't change.

  3. 
      
tardypad
pprkut
  1. Using a custom tag here is problematic in multiple ways, since you essentially really fork it at this point. The M2mobi 1.0.2 would be incompatible with an eventual upstream 1.0.2.

    Why not just point to the specific commit?

  2. 
      
tardypad
tardypad
pprkut
  1. Ship It!
  2. 
      
tardypad
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...