Vortex: add ApnsPHP response

Review Request #447 — Created May 26, 2016 and submitted

tardypad
Lunr
apns_php_response
446
lunr
Vortex: add ApnsPHP response

unit tests

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
pprkut
  1. 
      
  2. src/Lunr/Vortex/APNS/ApnsPHP/APNSResponse.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     

    I'd rather have the UNKNOWN status set in a default clause within the switch

  3. 
      
tardypad
pprkut
  1. 
      
  2. src/Lunr/Vortex/APNS/ApnsPHP/APNSResponse.php (Diff revision 2)
     
     
     
     

    why not directly foreach ($error['ERRORS'] as...)?

  3. 
      
tardypad
tardypad
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...