Vortex: make GCM dispatcher supports multicast

Review Request #439 — Created May 18, 2016 and submitted

Information
tardypad
Lunr
push_notification_dispatcher_multicast_gcm
Reviewers
lunr 
Vortex: make GCM dispatcher supports multicast
unit tests
  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
tardypad
pprkut
pprkut 
  1. Ship It!
  2. src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 2) 
     
     
    Show all issues 
    no more CURLOPT_HEADER?
    1. I didn't understood the reason it was there
      
Nothing was getting extracted from the headers present in the output
      
Only the HTTP code is retrieved but from the curl_getinfo result directly
      

      On the other side, I need to disable CURLOPT_FAILONERROR
      
Otherwise I can't access the content when the HTTP code is > 400
  3. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




tardypad




   

   

  

 



 















 





 

  

   




tardypad




   

   







  

 



 

  


   

   

    
 
tardypad


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/GCM/GCMDispatcher.php
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    I forgot to do this by batch:
    
only 1000 endpoints for one single push can be sent..
    
I'll fix this in another review
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      first shot done there: http://reviews.lunr.nl/r/448/
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




tardypad




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




tardypad




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...