-
-
src/Lunr/Vortex/PushNotificationResponseInterface.php (Diff revision 1) I don't understand this comment. Why NULL for only getting the status of one endpoint?
Vortex: prepare push notification response to contain result of multiple endpoints
Review Request #437 — Created May 17, 2016 and submitted
Information | |
---|---|
tardypad | |
Lunr | |
push_notification_response_endpoint | |
Reviewers | |
lunr | |
Vortex: prepare push notification response to contain result of multiple endpoints
unit tests
-
-
src/Lunr/Vortex/PushNotificationResponseInterface.php (Diff revision 1) This doesn't have to be NULL
But we should keep the behavior that the function can be called without argumentThis is for the non multicast calls.
Otherwise, we are forcing the following:$dispatcher->set_endpoints('abcde-12345') ->set_payload('payload') ->push() ->get_status('abcde-12345')
Not really elegant to have to repeat the endpoint
And can be annoying depending on where the status is retrieved from the response, we may not have a reference to the endpoint at that place
Change Summary:
get_status is always called with one endpoint parameter
Change Summary:
remove the NULL in the doc
Diff: |
Revision 3 (+379 -45)
|
---|