[Gravity] Modified the query method of MySQLQueryResult to return a shorter version of the query.

Review Request #433 — Created April 6, 2016 and discarded June 16, 2022, 5:51 p.m.

Information
Owner:	rubendgr
Repository:	Lunr
Branch:
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Changed MySQLQueryResult method query to return a query string consisting of crud operation (SELECT, INSERT,DELETE, etc) plus table name, replacing the full query. With a SELECT query it would return "SELECT FROM table [..]".

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
whitespace error	pprkut	April 7, 2016, 1:34 p.m.

Description:

~		[Gravity] Deleted a small piece of code in the MySQLQueryResult
	~	I changed the query method of the QueryResult class to return a short informative query. It was returning the full query and in the projects people implemented a string with a short query to replace this. With this change in the query method, you only have to ask the result for the query and you get a short informative query.

Description:

~		I changed the query method of the QueryResult class to return a short informative query. It was returning the full query and in the projects people implemented a string with a short query to replace this. With this change in the query method, you only have to ask the result for the query and you get a short informative query.
	~	I changed the query method of the QueryResult class to return a short informative query. It was returning the full query and in the projects people implemented a string with a short query to replace this. With this change in the query method, you only have to ask the result for the query and you get a short informative query for the logs.

Description:

~		I changed the query method of the QueryResult class to return a short informative query. It was returning the full query and in the projects people implemented a string with a short query to replace this. With this change in the query method, you only have to ask the result for the query and you get a short informative query for the logs.
	~	I changed the query method of the QueryResult class to return a short informative query. When there is an error in the query, you want to log the query and make a log message with it. The original query goes into this method and get shortened by getting the crud operation out of the original query and the table name. With these a new query string is constructed to use.

Description:

~		I changed the query method of the QueryResult class to return a short informative query. When there is an error in the query, you want to log the query and make a log message with it. The original query goes into this method and get shortened by getting the crud operation out of the original query and the table name. With these a new query string is constructed to use.
	~	Changed MySQLQueryResult method query to return a query string consisting of crud operation plus table name, replacing the full query. The crud operations are SELECT, INSERT, DELETE, UPDATE, REPLACE.

Description:

~		Changed MySQLQueryResult method query to return a query string consisting of crud operation plus table name, replacing the full query. The crud operations are SELECT, INSERT, DELETE, UPDATE, REPLACE.
	~	Changed MySQLQueryResult method query to return a query string consisting of crud operation (SELECT, INSERT,DELETE, etc) plus table name, replacing the full query. With a SELECT query it would return "SELECT FROM table [..]".

Change Summary:

When making the shorter messages, mutli-table deletes are taken into consideration.

Diff:

Revision 2 (+37 -1)

Show changes

src/Lunr/Gravity/Database/MySQL/MySQLQueryResult.php

Right idea, but several architectural shortcomings. This should give reasonable results with any query you throw at it, not just run-of-the-mill simpleton queries.
Examples:
SELECT UUID();

SELECT DISTINCT SQL_CALC_FOUND_ROWS col1, FUNCTION() as col2 FROM (SELECT * FROM table1) LIMIT 10;

DELETE LOW_PRIORITY table1 FROM table2 JOIN table1;

DELETE FROM table1 USING table2 JOIN table1;

SHOW VARIABLES;
Additionally, we don't always want the shortened query, so there needs to be still a way to get to the full one.