[Corona] adding caching for get_raw_data

Review Request #418 — Created Feb. 17, 2016 and submitted Feb. 19, 2016, 4:43 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	personal/sean/cache_parse_raw
Bugs:
Depends On:
Commit:	a03cd5e...
Reviewers
Groups:	lunr
People:

Description

Corona: adding caching for get_raw_data

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
I think the result should be cached every time whatever it is maybe only unless parse_raw_data failed (which should be ...	tardypad	Feb. 17, 2016, 4:13 p.m.
I don't understand this parse_raw_data can't return different consecutive things for a same request/object, no?	tardypad	Feb. 17, 2016, 4:13 p.m.

src/Lunr/Corona/Request.php (Diff revision 1)

Show all issues

I think the result should be cached every time whatever it is
maybe only unless parse_raw_data failed (which should be when its result is FALSE AFAICS)

smillernl Feb. 17, 2016, 4:01 p.m.

parse_raw_data returns an empty string because it doesn't fail, stdin is just empty.

pprkut Feb. 17, 2016, 4:15 p.m.

I'd rather not have the parser read repeatedly. It's not meant to be used interactively, so forcing it to be one-off would be better IMHO.

src/Lunr/Corona/Tests/RequestGetTest.php (Diff revision 1)

Show all issues

I don't understand this

parse_raw_data can't return different consecutive things for a same request/object, no?

smillernl Feb. 17, 2016, 4:01 p.m.

If you call something that calls get_raw_data multiple times it'd read stdin multiple times, clearing it after the first one.

pprkut Feb. 17, 2016, 4:15 p.m.

While theoretically you can have an application read multiple times from stdin, the usual usecase for this would be a cli application asking for user input. And the request parser is not meant for such a use-case.
So stdin in the parser context is input coming from either the (web) request body, or the (cli) pipe.