Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+57 -34) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+55 -34) |
-
-
src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 3) I think this part is not unit tested
Also I would return FALSE in case of an error like done elsewhere
Since you've changed what this function can return, make sure as well that this new case is handled correctly where you call it
-
src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 3) errors might happen making the http response not a correct JSON
Change Summary:
Unittests for potential Oauth failures
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+118 -34) |
Change Summary:
Upped the logging level
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+126 -34) |
-
-
src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 5) I don't feel this is the correct way to check if an error occured with the request.
From what I see, the result is either FALSE or NULL on failure.
I think you better check the error_number returned -
src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 5) this key is not necessarily in the json object response
Change Summary:
Fixed some Oauth things
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+161 -34) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+166 -34) |