[Core] Model class adapted to 0.2

Review Request #41 — Created Jan. 16, 2013 and submitted

Felipe
Lunr
https://github.com/madsmash/lunr/tree/update
lunr
Legacy code removed from Model class

depends on http://reviews.lunr.nl/r/40/


pprkut
  1. Given the emptyness of that class for now I'm still not sure whether we want this abstract or as an interface.
    If we keep it abstract we do need basic unit test infra for it as well, even if there is nothing to test.
    1. I guess right now it doesn't make much difference... What is the idea behind this class? what shared code is it supposed to have?
    2. If I would have an idea it wouldn't be empty :P
      The only thing I can think of is a ways to handle multiple DAOs, but then again I couldn't think of a reasonable way to do that. Maybe data transformation helpers or some such
    3. I thought about this and I'd say make this an Interface for now. When we need dedicated functionality in a Model class we can reevaluate what to do.
  2. 
      
Felipe
Felipe
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master
Loading...