[Vortex] Adding WNS Dispatcher

Review Request #405 — Created Jan. 13, 2016 and submitted

smillernl
Lunr
personal/sean/wns_notification_dispatcher
715ded9...
lunr
Vortex: Adding WNS Dispatcher


  • 0
  • 0
  • 5
  • 2
  • 7
Description From Last Updated
pprkut
  1. 
      
  2. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    what if there is no oauth token set?

  3. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    indentation

  4. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     
     
     
     
     
     
     
     

    indentation

  5. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    Are you sure about this?

    1. From the official documentation
      __Content-Type(Required):__Standard HTTP authorization header. For toast, tile, and badge notifications, this header must be set to "text/xml". For raw notifications, this header must be set to "application/octet-stream".

  6. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    should probably be a class constant

  7. src/Lunr/Vortex/WNS/WNSType.php (Diff revision 1)
     
     
     
     
     
     

    You don't have a payload class for that in http://reviews.lunr.nl/r/407/

  8. 
      
smillernl
  1. 
      
  2. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    From the official documentation
    __Content-Type(Required):__Standard HTTP authorization header. For toast, tile, and badge notifications, this header must be set to "text/xml". For raw notifications, this header must be set to "application/octet-stream".

  3. 
      
smillernl
smillernl
pprkut
  1. 
      
  2. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 3)
     
     
     
     
     
     
     
     
     

    indentation

    1. Must be the new coffee beans.

  3. 
      
smillernl
smillernl
Review request changed

Status: Closed (submitted)

Loading...