[Vortex] GCM: Updating endpoint

Review Request #401 — Created Jan. 7, 2016 and submitted Jan. 11, 2016, 4:51 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	personal/sean/gcm_notification_update
Bugs:
Depends On:
Blocks:	404
Commit:	c916dad...
Reviewers
Groups:	lunr
People:

Description

Vortex: Updating endpoint

All but one of the GCM documentation pages use the changed URL but I can't find any official documentation on them changing URLS. Even though it would make sense with the addition of iOS capabilities to drop the URL that featured android as part of the domain.

Testing Done

Branch:

+	personal/sean/gcm_notification_update

Description:

		Vortex: Adding priority option and updating endpoint
	+
	+	All but one of the GCM documentation pages use the changed URL but I can't find any official documentation on them changing URLS. Even though it would make sense with the addition of iOS capabilities to drop the URL that featured android as part of the domain.
	+
	+	As for the `set_priority()` this enables us to send priority notifications which will behave differently on android.

Generally this looks fine, but...

All other systems where it applies have priority setting in the dispatcher and I see no reason to not have it the same for GCM.
Priority and different URL are independent changes, so should go into separate commits.
Unit tests are missing

Summary:

-	[Vortex] GCM: Adding priority option and updating endpoint
+	[Vortex] GCM: Updating endpoint

Description:

~		Vortex: Adding priority option and updating endpoint
	~	Vortex: Updating endpoint

		All but one of the GCM documentation pages use the changed URL but I can't find any official documentation on them changing URLS. Even though it would make sense with the addition of iOS capabilities to drop the URL that featured android as part of the domain.
-
-		As for the `set_priority()` this enables us to send priority notifications which will behave differently on android.

Commit:

-	64006b2fafb09094973cb0ce00b189c811bec306
+	c916dad219207c14c48ff00bf5227ee5cbaf3dfa

Diff:

Revision 2 (+8 -6)

Show changes

	src/Lunr/Vortex/GCM/GCMDispatcher.php
	src/Lunr/Vortex/GCM/GCMPayload.php
	src/Lunr/Vortex/GCM/Tests/GCMDispatcherPushTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[Vortex] GCM: Updating endpoint

Branch:

Description:

Summary:

Description:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: