Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

[Corona] adding a check for an empty HTTP Accept Header

Review Request #395 — Created Nov. 11, 2015 and submitted Jan. 11, 2016, 5:04 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	personal/sean/accept_header_null
Bugs:
Depends On:
Commit:	bfbeb3b...
Reviewers
Groups:	lunr
People:

Description

Corona: adding a check for an empty HTTP Accept Header

Testing Done

Description:

~		Corona: adding a check for an empty HTTP Accept Header
	~	Corona: adding a check for an empty HTTP Accept Header
-		damien found: `PHP Notice: Undefined index: HTTP_ACCEPT in /var/www/apps/Lunr-0.2/src/Lunr/Corona/WebRequestParser.php on line 288`
-		In the logs, this should fix that.

Diff:

Revision 2 (+7 -4)

src/Lunr/Corona/WebRequestParser.php

```
Fix looks good. Please add unit tests
```

Commit:

-	34106e4be41b2e00672185030192a094025c7ebd
+	b942e7e02691c6f96bcb544d03f83637fe12ba16

Diff:

Revision 3 (+32 -4)

	src/Lunr/Corona/WebRequestParser.php
	src/Lunr/Corona/Tests/WebRequestParserAcceptTest.php

I suppose if we need it for accept format we also need it for accept language and accept charset, no? Please add them as well.

Commit:

-	b942e7e02691c6f96bcb544d03f83637fe12ba16
+	bfbeb3bc98dc02e5495ab55332f9401391473445

Diff:

Revision 4 (+90 -10)

	src/Lunr/Corona/WebRequestParser.php
	src/Lunr/Corona/Tests/WebRequestParserAcceptTest.php

Branch:

+	personal/sean/accept_header_null

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...