-
-
-
-
src/Lunr/Corona/FrontController.php (Diff revision 1) define "$controller = '';" before the foreach for in case there is no path at all. Or "return '';" in the end of the function and "return $controller;" instead of the "break;"
-
-
src/Lunr/Corona/Tests/FrontControllerLookupTest.php (Diff revision 1) maybe add a third paths in here, just to test that the lookup stops as soon as it finds a controller
-
src/Lunr/Corona/Tests/FrontControllerLookupTest.php (Diff revision 1) I think we should have an extra failure test in case no path is defined at all.
-
src/Lunr/Corona/Tests/FrontControllerRouteTest.php (Diff revision 1) I think it is confusing to use foo/bar everywhere the first 'foo/bar' is meant for 'controller/method' while the second one is a folder path That makes the tests difficult to read
Change Summary:
Fixes for error edge cases.
Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+570 -2) |