[Network][RFC] PSR7 execution implementetion in Twitter API use case

Review Request #377 — Created July 10, 2015 and discarded Dec. 9, 2016, 1:09 p.m.

Information
Owner:	Pol
Repository:	Lunr
Branch:
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Network: PSR7 execution implementetion in Twitter API use case

Testing Done

Issues

6
0
0
0
All Issues: 6

Description	From	Last Updated
why would send() get a received Request message?	pprkut	July 13, 2015, 11:41 p.m.
This is the "Executor" class. The idea is the controller or API build or it sends the request to this ...	Pol	July 14, 2015, 1:21 p.m.
Do we need this?	pprkut	July 13, 2015, 11:41 p.m.
Not necessary, but if we follow the specification, there is stored the POST data from a request object. If not, ...	Pol	July 14, 2015, 1:25 p.m.
we already have the http status codes in Corona	pprkut	July 13, 2015, 11:41 p.m.
Okay, i will looking for this class and I will replace it.	Pol	July 14, 2015, 1:25 p.m.

Fix it!

Please redo this and modify the actual classes we have now instead of working with copies.
As it is, it is rather difficult to see what's different from what we have now.

Still mentioning a few small things:

pprkut July 14, 2015, 12:43 a.m.

Actually, nevermind. Reading the spec again I'm not even sure I want this anymore :(

src/Lunr/Network/Http/CurlHttpClient.php (Diff revision 1)
Show all issues
```
why would send() get a received Request message?
```
src/Lunr/Network/Http/ServerRequest.php (Diff revision 1)
Show all issues
```
Do we need this?
```
src/Lunr/Network/Http/StatusCode.php (Diff revision 1)
Show all issues
```
we already have the http status codes in Corona
```

Fix it!

src/Lunr/Network/Http/CurlHttpClient.php (Diff revision 1)

Show all issues

This is the "Executor" class. The idea is the controller or API build or it sends the request to this model which his only responsibility is to retrieve a response from a given request.

Fix it!

src/Lunr/Network/Http/ServerRequest.php (Diff revision 1)

Show all issues

Not necessary, but if we follow the specification, there is stored the POST data from a request object. If not, we can put it into a normal Request class.

src/Lunr/Network/Http/StatusCode.php (Diff revision 1)
Show all issues
```
Okay, i will looking for this class and I will replace it.
```

You have a pending review.

Review Board 3.0.24

[Network][RFC] PSR7 execution implementetion in Twitter API use case

Status: Discarded