[Network][RFC] PSR7 execution implementetion in Twitter API use case

Review Request #377 — Created July 10, 2015 and discarded

Information
Pol
Lunr
Reviewers
lunr 
Network: PSR7 execution implementetion in Twitter API use case




 













 

 






 
 
 

  

   
  

  
    
   
  • 
    
    6
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    0
   
    • 
   
  • 
    
    6
   
    • 
  

 

 

  

   
    

     Description
     From
     Last Updated
    

   
   


    

     
      
      why would send() get a received Request message?
     
     
      

       pprkut


       pprkut
      
     
     
      
     
    



    

     
      
      This is the "Executor" class. The idea is the controller or API build or it sends the request to this ...
     
     
      

       Pol


       Pol
      
     
     
      
     
    



    

     
      
      Do we need this?
     
     
      

       pprkut


       pprkut
      
     
     
      
     
    



    

     
      
      Not necessary, but if we follow the specification, there is stored the POST data from a request object. If not, ...
     
     
      

       Pol


       Pol
      
     
     
      
     
    



    

     
      
      we already have the http status codes in Corona
     
     
      

       pprkut


       pprkut
      
     
     
      
     
    



    

     
      
      Okay, i will looking for this class and I will replace it.
     
     
      

       Pol


       Pol
      
     
     
      
     
    


   
  

 












  

 








 














 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Please redo this and modify the actual classes we have now instead of working with copies.
As it is, it is rather difficult to see what's different from what we have now.

Still mentioning a few small things:
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Actually, nevermind. Reading the spec again I'm not even sure I want this anymore :(
      
 
      

      2. 


 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    why would send() get a received Request message?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Network/Http/ServerRequest.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Do we need this?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Network/Http/StatusCode.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    we already have the http status codes in Corona
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 





 

  

   




Pol




   

   







  

 



 

  


   

   

    
 
Pol


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    This is the "Executor" class. The idea is the controller or API build or it sends the request to this model which his only responsibility is to retrieve a response from a given request.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




Pol




   

   







  

 



 

  


   

   

    
 
Pol


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Network/Http/ServerRequest.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Not necessary, but if we follow the specification, there is stored the POST data from a request object. If not, we can put it into a normal Request class.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Network/Http/StatusCode.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    An issue was opened.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Okay, i will looking for this class and I will replace it.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




Pol




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...