pprkut
-
-
-
-
-
src/Lunr/Network/StreamSocket.php (Diff revision 1) unify to set_timeout like detailed on the mailing list
-
-
-
-
-
-
-
src/Lunr/Network/StreamSocketClient.php (Diff revision 1) make them protected. I expect the buffered client might want to use them
-
src/Lunr/Network/StreamSocketClient.php (Diff revision 1) misleading. You want a URI here, not an actual established socket
-
-
-
-
-
-
tests/system/libraries/spwn/ResqueJobDispatcherTest.php (Diff revision 1) This does not belong in this review
[Network] add stream socket API with StreamSocketClient class
Review Request #36 — Created Jan. 7, 2013 and submitted
| Information | |
|---|---|
| olivier | |
| Lunr | |
| https://github.com/owizen/lunr/tree/streamclient | |
| 12249 | |
| Reviewers | |
| lunr | |
This is the last version of streamSocket and StreamSocketClient classes: select method renamed as discussed in https://groups.google.com/forum/?hl=en&fromgroups=#!topic/lunr-developers/K0EK9w3l6Pc the read_all and read_chunk methods have been removed and the read method make use of stream-get-contents with a default parameter of -1. http://php.net/manual/en/function.stream-get-contents.php That review replaces http://reviews.lunr.nl/r/7/ and http://reviews.lunr.nl/r/10/ Note: the remve_flag method was removed after discussion but not restored, the need of such method doesn't seem to be so important.
Unit tests, live push to APNS
Change Summary:
Method set_timeout replacing timeout_seconds and timeout_microseconds setters Unit tests updated and passed, code coverage 100%. Change made according to review, code style fixed with phpcs.
Change Summary:
improve notification callback management, unit test updated, code style passed.
Diff: |
Revision 3 (+3066)
|
|---|