This is the last version of streamSocket and StreamSocketClient classes:
select method renamed as discussed in https://groups.google.com/forum/?hl=en&fromgroups=#!topic/lunr-developers/K0EK9w3l6Pc
the read_all and read_chunk methods have been removed and the read method make use of stream-get-contents with a default parameter of -1.
http://php.net/manual/en/function.stream-get-contents.php
That review replaces http://reviews.lunr.nl/r/7/ and http://reviews.lunr.nl/r/10/
Note: the remve_flag method was removed after discussion but not restored, the need of such method doesn't seem to be so important.
Method set_timeout replacing timeout_seconds and timeout_microseconds setters
Unit tests updated and passed, code coverage 100%.
Change made according to review, code style fixed with phpcs.
This has seen enough reviews and plenty of eyes. I'd say it's in a very much reasonable state now (except for the occasional coding style issue ¬_¬).
If we encounter any difficulties with this we can improve as we go.
Nice Job! :)
pprkut
