[DataAccess] Method reorganization and cleanup/compress query building methods

Review Request #34 — Created Dec. 28, 2012 and submitted

Information
pprkut
Lunr
pprkut/l10n
Reviewers
lunr 
Move abstract methods into interfaces and synchronize positioning between files.
Cleanup and compress query generating methods.

This depends on http://reviews.lunr.nl/r/30/
Unit tests
olivier
olivier 
  1. I like the idea of making more interfaces, fits the DI pattern requirements.
As it doesn't impact the unit tests except for the intvalue that moved from mysql to
the abstract query builder, it looks "shippable" once unit tests are updated.
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 















 





 

  

   




olivier




   

   







  

 



 

  


   

   

    
 
olivier


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




Felipe




   

   







  

 



 

  


   

   

    
 
Felipe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...