-
-
The changes in Halo go with the changes in Sqlite3 (put a function mock_method in LunrBaseTest so that it can be reused if needed) The changes in phpunit.xml is really straigtforward (just changed relative paths)
-
Right, the changes form a semantic whole, but each change can perfectly stand on its own. Ie, we can absolutely make use of mock_method() without ever upgrading phpunit. Same about the Sqlite3 change. If you absolutely want to keep them together, that's fine. But you'll need to accept that that will likely slow down merging of the entire change set.
-
-
Update to work with phpunit 4.1.3
Review Request #322 — Created July 8, 2014 and discarded
| Information | |
|---|---|
| tardypad | |
| Lunr | |
| tardypad:phpunit-4.1.3 | |
| Reviewers | |
| lunr | |
Change of relative paths in configuration file staticExpects is deprecated Mocking of static methods is not supported anymore Running phpunit is taking much much more time and memory for me on my local environment... phpunit-3.7.37: Time: 1.15 minutes, Memory: 85.25Mb phpunit-4.1.3: Time: 11.68 minutes, Memory: 199.50Mb Please test and let me know if it's the same for you to see if this needs further investigation
