[Gravity] FAO file_exists wrapper

Review Request #307 — Created May 15, 2014 and updated June 3, 2014, 1:47 p.m.

Information
Owner:	dinos
Repository:	Lunr
Branch:	dinostheo:FileExists
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Adds a FAO wrapper for the file_exists function as well as checks filetype and compares file values.

Testing Done

unit tests

Issues

2
0
1
0
All Issues: 3

Description	From	Last Updated
explanation sounds weird	pprkut	May 24, 2014, 5:43 p.m.
Not sure if possible, but could we set the default value to the constant?	pprkut	May 28, 2014, 4:56 p.m.
I checked file and dir, not sure if block and char are affected as well. Bash behaviour is to follow ...	pprkut	May 24, 2014, 5:43 p.m.

Change Summary:

Changed completely the structure of the implemented function

Description:

~		Adds a FAO wrapper for the file_exists function.
	~	Adds a FAO wrapper for the file_exists function as well as checks filetype and compares file values.
-		It also changes the mkdir to make use of the FAO file_exists. That is also the reason of the dependency #306

Depends On:

-	~~306 - [Gravity] Wrapper for the mkdir function~~

Diff:

Revision 2 (+632)

Show changes

	src/Lunr/Gravity/Filesystem/FileFlags.php
	src/Lunr/Gravity/Filesystem/FilesystemAccessObjectInterface.php
	src/Lunr/Gravity/Filesystem/PhysicalFilesystemAccessObject.php
	src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectFileExistsTest.php
	src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectTest.php
	tests/phpunit.xml

Fix it!

src/Lunr/Gravity/Filesystem/FileFlags.php (Diff revision 2)

Show all issues

explanation sounds weird

dinos May 28, 2014, 4:56 p.m.

taken from the man pages
http://www.cyberciti.biz/faq/unix-linux-test-existence-of-file-in-bash/

pprkut June 3, 2014, 1:47 p.m.

I'd just go with "file exists and is a block special file". When you have a "pdf file" you also don't say "This file is pdf"

src/Lunr/Gravity/Filesystem/FilesystemAccessObjectInterface.php (Diff revision 2)
Show all issues
```
Not sure if possible, but could we set the default value to the constant?
```

src/Lunr/Gravity/Filesystem/PhysicalFilesystemAccessObject.php (Diff revision 2)

Show all issues

I checked file and dir, not sure if block and char are affected as well. Bash behaviour is to follow the symlink. So a symlink pointing to a directory would return TRUE at a "-d" check. I don't think that's the case here.

dinos May 26, 2014, 10:51 a.m.

is_dir() and is_file could substitute those 2, as they return TRUE in case that are symlinks to a directory and a file respectively. I will have to test further for block and char.

You have a pending review.

Review Board 3.0.24

[Gravity] FAO file_exists wrapper

Change Summary:

Description:

Depends On:

Diff: