[Gravity] Query Deadlock Handling

Review Request #292 — Created April 17, 2014 and submitted April 22, 2014, 9:58 a.m.

Information
Owner:	dinos
Repository:	Lunr
Branch:	dinostheo:DeadlockHandling
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Method for handling deadlocks and re-executing the query

Testing Done

unit tests

Issues

Description	From	Last Updated
Wrong documentation. Also, effort_number sounds weird... I'd use retry_count	pprkut	April 18, 2014, 11:11 a.m.
I'd go for a for loop, since you are clearly bounded	pprkut	April 18, 2014, 11:14 a.m.
should be fine as a ternary	pprkut	April 18, 2014, 11:10 a.m.
Here you test that if, but not the while. Can you add another test that checks that the while statement ...	pprkut	April 18, 2014, 11:19 a.m.

Ship it!

src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 1)

Show all issues

Wrong documentation. Also, effort_number sounds weird... I'd use retry_count

src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 1)
Show all issues
```
I'd go for a for loop, since you are clearly bounded
```
src/Lunr/Gravity/Database/MySQL/MySQLQueryResult.php (Diff revision 1)
Show all issues
```
should be fine as a ternary
```

src/Lunr/Gravity/Database/Tests/DatabaseAccessObjectResultsTest.php (Diff revision 1)

Show all issues

Here you test that if, but not the while. Can you add another test that checks that the while statement works as intended?

A few modifications based on the last review. 
Rebased against master

	src/Lunr/Gravity/Database/DatabaseAccessObject.php
	src/Lunr/Gravity/Database/DatabaseQueryResultInterface.php
	src/Lunr/Gravity/Database/MySQL/MySQLQueryResult.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultFailedTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseAccessObjectResultsTest.php

Ship it!

Ship it!

Merged into master

You have a pending review.