This change has been marked as submitted.

Describe the submission (optional):

Merged into master

Reviews
Diff

- Download Diff

Summary:

[Vortex] Remove $config dependency from GCMDispatcher

Review Request #284 — Created March 25, 2014 and submitted 11 years, 2 months ago — Latest diff uploaded 11 years, 2 months ago

Information
Owner:	leo*
Repository:	Lunr
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Vortex: Remove $config dependency from GCMDispatcher

Also, removed the invalidation of the endpoint after pushing because
it is needed by the GCMResponse class for logging.

Testing Done

unit tests, example push notifications sent

Changes between revision 1 and 2

orig

	src/Lunr/Vortex/GCM/GCMDispatcher.php
	src/Lunr/Vortex/GCM/Tests/GCMDispatcherPushTest.php

Expand changes
Hide extra whitespace
Show extra whitespace
Hide whitespace changes
Show whitespace changes

src/Lunr/Vortex/GCM/GCMDispatcher.php

src/Lunr/Vortex/GCM/Tests/GCMDispatcherPushTest.php

You have a pending review.

Review Board 3.0.24

This change has been marked as submitted.

[Vortex] Remove $config dependency from GCMDispatcher

Changes between revision 1 and 2