[Vortex] Remove $config dependency from GCMDispatcher

Review Request #284 — Created March 25, 2014 and submitted March 26, 2014, 10:42 a.m.

Information
Owner:	leo
Repository:	Lunr
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Vortex: Remove $config dependency from GCMDispatcher

Also, removed the invalidation of the endpoint after pushing because
it is needed by the GCMResponse class for logging.

Testing Done

unit tests, example push notifications sent

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
The config removal is fine, but this is quite controversial. It's obviously a bug, but not clearing the endpoint after ...	pprkut	March 26, 2014, 10:25 a.m.

Ship it!

```
Ship It!
```

src/Lunr/Vortex/GCM/GCMDispatcher.php (Diff revision 1)

Show all issues

The config removal is fine, but this is quite controversial. It's obviously a bug, but not clearing the endpoint after a push is as well.

leo March 26, 2014, 10:26 a.m.

controversy will be moved to another review

Change Summary:

removed controversial changes

Diff:

Revision 2 (+8 -39)

Show changes

	src/Lunr/Vortex/GCM/GCMDispatcher.php
	src/Lunr/Vortex/GCM/Tests/GCMDispatcherPushTest.php
	src/Lunr/Vortex/GCM/Tests/GCMDispatcherTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[Vortex] Remove $config dependency from GCMDispatcher

Change Summary:

Diff:

Status: Closed (submitted)

Change Summary: