-
-
src/Lunr/Vortex/APNS/APNSDispatcher.php (Diff revision 1) Do you really have to go through the whole init/destroy mechanism in the push() method? Can't we like set it up in the constructor, and destroy it in the destructor? Would seem much more resource friendly to me
-
src/Lunr/Vortex/APNS/Tests/APNSDispatcherPushTest.php (Diff revision 1) I would have a constant for the mock code, like we do it everywhere else
-
src/Lunr/Vortex/APNS/Tests/APNSDispatcherPushTest.php (Diff revision 1) probably a foreach would make that more readable
Change Summary:
enforced a bit of resource housekeeping, adjusted unit tests
Depends On: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+630) |