[Vortex] Add the APNSDispatcher class

Review Request #282 — Created March 19, 2014 and submitted

leo
Lunr
leo:apns_response
lunr
Vortex: Add the APNSDispatcher class
unit tests
  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
There are no open issues
pprkut
  1. 
      
  2. src/Lunr/Vortex/APNS/APNSDispatcher.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues
    Do you really have to go through the whole init/destroy mechanism in the push() method? Can't we like set it up in the constructor, and destroy it in the destructor? Would seem much more resource friendly to me
  3. The issue has been resolved. Show all issues
    I would have a constant for the mock code, like we do it everywhere else
  4. src/Lunr/Vortex/APNS/Tests/APNSDispatcherPushTest.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues
    probably a foreach would make that more readable
  5. 
      
leo
pprkut
  1. Ship It!
  2. 
      
leo
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master
Loading...