[GCM] Wraps the curl headers of dispatch in an array

Review Request #250 — Created Dec. 3, 2013 and discarded

Information
dinos
Lunr
dinostheo:GCMDispatchBug
Reviewers
lunr 
The headers set in curl, in the GCMDispatch push() method should be in an array. 
unit tests
dinos
pprkut
pprkut 
  1. This is essentially adding multicast support to GCM. Given that I'm hesitant to just wave that through without considering how that is going to work in other services.
Also, the interface for set_endpoint() demands the parameter to be a string. Allowing arrays breaks the interface.
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




dinos




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 




 
Change Summary:

 
not a bug fix





 


 










  

 









     

    

   

  

  

   
   Loading...