[Network] Porting StreamSocket Tests to LunrBaseTest

Review Request #244 — Created Nov. 20, 2013 and submitted Nov. 20, 2013, 4:17 p.m.

Description

Porting StreamSocket Tests to LunrBaseTest.


THIS REVIEW REPLACES #216

Testing Done

unit tests

Issues

Description	From	Last Updated
assertPropertyEquals	pprkut	Nov. 20, 2013, 3:24 p.m.
assertInternalType	pprkut	Nov. 20, 2013, 3:24 p.m.
where's runkit in there?	pprkut	Nov. 20, 2013, 3:25 p.m.
that's mock_function()	pprkut	Nov. 20, 2013, 3:28 p.m.
that's unmock_function	pprkut	Nov. 20, 2013, 3:28 p.m.
missing unmock	pprkut	Nov. 20, 2013, 3:29 p.m.
you can drop the @runInSeparateProcess tags here	pprkut	Nov. 20, 2013, 3:36 p.m.

src/Lunr/Network/Tests/StreamSocketClientHandleTest.php (Diff revision 1)

Show all issues

where's runkit in there?

src/Lunr/Network/Tests/StreamSocketClientHandleTest.php (Diff revision 1)

Show all issues

missing unmock

A few changes based on the last review

Revision 2 (+537 -742)

	src/Lunr/Network/Tests/StreamSocketBaseTest.php
	src/Lunr/Network/Tests/StreamSocketClientBaseTest.php
	src/Lunr/Network/Tests/StreamSocketClientFlagsTest.php
	src/Lunr/Network/Tests/StreamSocketClientHandleTest.php
	src/Lunr/Network/Tests/StreamSocketClientReadWriteTest.php
	src/Lunr/Network/Tests/StreamSocketClientTest.php
	src/Lunr/Network/Tests/StreamSocketContextTest.php
	src/Lunr/Network/Tests/StreamSocketSetGetTest.php
	2 more

Ship it!

Merged into master

You have a pending review.