[Core] Session class

Review Request #22 — Created Dec. 6, 2012 and submitted

Information
Felipe
Lunr
master
Reviewers
lunr 
Class that deals with session handling. Unit tests in progress, please comment if you see something wrong.
Unit Tests
  • 0
  • 0
  • 17
  • 0
  • 17
Description From Last Updated
There are no open issues
olivier
olivier 
  1. Looks fine and simple, I would say ship it!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




olivier




   

   







  

 



 

  


   

   

    
 
olivier


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      No no no no no no nooooooo!! no shipits without unittests!!
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      system/libraries/core/class.session.inc.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    I was trying to keep that list alphabetical...
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      system/libraries/core/class.session.inc.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    not necessary
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      system/libraries/core/class.session.inc.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Code style
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    not necessary
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 






  6. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Code style
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    not necessary
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 




  8. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    9. 




  

 
















 



 

  

   




Felipe




   

   

  

 



 















 



 

  

   




Felipe




   

   

  

 



 















 



 

  

   




Felipe




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Mostly fine
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Session.php
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    this should return NULL
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Session.php
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    early exit
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionTest.php
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    I have the feeling phpcs will complain here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      yep, it complained because I didn't have a white line between this constant and the first function :P
      
 
      

      2. 


 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




Felipe




   

   

  

 



 















 



 

  

   




Felipe




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Session.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    5.4
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Session.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    not in between __construct() and __destruct()
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    This is not sufficient, since you don't test the passed parameters. Please add tests for expected and unexpected parameters.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    'set' is already public
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 






  6. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    ditto
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    ditto
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 






  8. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    ditto
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    9. 






  9. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    I'd add an assertArrayHasKey or whatever it's called before
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    10. 






  10. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    not necessary, just declare it @runInSeparateProcess
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    11. 






  11. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    ok, so just to be sure, you really only need this if the method is protected or private
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    12. 






  12. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    wrong name
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      could I get an example that your Majesty likes? :P 

http://devopsreactions.tumblr.com/post/37780353353/code-review-reviewee
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      well, it returns NULL not FALSE :P
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      I realized that just a few seconds after replying.... (facepalm)

      
 
      

      4. 


 
    


    

 
    

    13. 






  13. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Core/Tests/SessionBaseTest.php
      


       (Diff revision 5)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been resolved.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    wrong name
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    14. 




  14. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    15. 




  

 
















 



 

  

   




Felipe




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




Felipe




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...