[Gravity] [Tests] Fixed test "testPutFileContentWithNonExistantFile"

Review Request #193 — Created Oct. 23, 2013 and submitted Oct. 27, 2013, 7:25 p.m.

Information
Owner:	andrea
Repository:	Lunr
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

This test was failing consistently after the first time if ran on the same machine. This is due to the fact that a file is being created in the test, but never deleted, leading to permission error when trying to override.

Testing Done

Unit tests.

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
If this doesn't return an object, it throws an exception in which case you need to also expect the logger ...	pprkut	Oct. 24, 2013, 1:18 p.m.

Diff:

Revision 2 (+6 -1)

Show changes

src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectFileTest.php

src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectFileTest.php (Diff revision 2)

Show all issues

If this doesn't return an object, it throws an exception in which case you need to also expect the logger call.

andrea Oct. 24, 2013, 1:18 p.m.

Ok, I noticed in the get_file_object method that it returns FALSE if that exception is caught, hence the fix. Checking also the logger call cannot hurt of course, so.. fixed in next review.

Change Summary:

Expecting to log the the Exception message too.

Diff:

Revision 3 (+12 -1)

Show changes

src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectFileTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[Gravity] [Tests] Fixed test "testPutFileContentWithNonExistantFile"

Diff:

Change Summary:

Diff:

Status: Closed (submitted)

Change Summary: