[Spark] Twitter Authentication class

Review Request #176 — Created Oct. 11, 2013 and submitted Oct. 23, 2013, 10:09 a.m.

Information
Owner:	dinos
Repository:	Lunr
Branch:	dinostheo:TwitterAuthentication
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Implements the authentication class that fetches the App-Authentication-Only token (bearer token) and stores it in the cas.

Testing Done

unit tests

Issues

Description	From	Last Updated
Looks like a bugfix for http://reviews.lunr.nl/r/175/ no?	pprkut	Oct. 15, 2013, 1:35 p.m.
uhm, huh?	pprkut	Oct. 15, 2013, 1:51 p.m.
IMHO this should return only the token here. What else would you need from that array?	pprkut	Oct. 22, 2013, 3:15 p.m.

src/Lunr/Spark/Twitter/Api.php (Diff revision 1)

Show all issues

Looks like a bugfix for http://reviews.lunr.nl/r/175/ no?

src/Lunr/Spark/Twitter/Tests/AuthenticationApiTest.php (Diff revision 1)
Show all issues
```
uhm, huh?
```
```
Otherwise looks good :)
```

small fixes based to the last review

-	~~153 - [Vortex] GCM response~~

	src/Lunr/Spark/Twitter/Authentication.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationApiTest.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationBaseTest.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationTest.php
	tests/phpunit.xml

src/Lunr/Spark/Twitter/Authentication.php (Diff revision 2)

Show all issues

IMHO this should return only the token here. What else would you need from that array?

Returns the access token instead of an array containing the access token. ALso rebased against master.

	src/Lunr/Spark/Twitter/Authentication.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationApiTest.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationBaseTest.php
	src/Lunr/Spark/Twitter/Tests/AuthenticationTest.php
	tests/phpunit.xml

Ship it!

Merged into master

You have a pending review.