[Corona] PHP session cookie exception

Review Request #163 — Created Oct. 1, 2013 and submitted Oct. 1, 2013, 4:47 p.m.

Information
Owner:	dinos
Repository:	Lunr
Branch:	dinostheo:SessionCookie
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

In the Request class we store the cookies locally and then we unset the global cookie variable. This affects the use of the global session variable as it is stored in a cookie (PHPSESSID). This patch adds an exception in the global cookie invalidation by letting the PHPSESSID untouched.

Testing Done

unit tests

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
I'd prefer if you add another test for php session data, as these tests are still valid for the case ...	pprkut	Oct. 1, 2013, 2:17 p.m.

Summary:

-	Corona: PHP session cookie exception
+	[Corona] PHP session cookie exception

src/Lunr/Corona/Tests/RequestStoreCookieTest.php (Diff revision 1)

Show all issues

I'd prefer if you add another test for php session data, as these tests are still valid for the case when there is no session data.

Change Summary:

reverts the changes in the test cookie store function and adds an extra testcase for the PHPSESSID

Diff:

Revision 2 (+30 -1)

Show changes

	src/Lunr/Corona/Request.php
	src/Lunr/Corona/Tests/RequestStoreCookieTest.php
	src/Lunr/Corona/Tests/RequestTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[Corona] PHP session cookie exception

Summary:

Change Summary:

Diff:

Status: Closed (submitted)

Change Summary: