[DataAccess] Replace MySQLnd Mocks with Composite MySQLi Mocks.

Review Request #16 — Created Nov. 25, 2012 and submitted

Information
pprkut
Lunr
master
Reviewers
lunr 
This replaces the existing MySQLnd MySQL Connection Mocks with Composite Mocks of the MySQLi class.
The MySQLnd Mocks rely on mysqlnd_uh, which is not yet available on PHP 5.4. Using the Composite Mocks we now have Lunr fully supported on 5.4 as well.
Unit Tests
Felipe
Felipe 
  1. Why the successful connection mock? I thought we only needed one for mocking failed connections
    1. So how would you then check a successful connection to a database without actually connecting to a database? :)
    2.         $this->mysqli->expects($this->once())
                     ->method('connect')
                     ->with('ro_host', 'username', 'password', 'database', $port, $socket);

??
    3. This works for the call to connect(), but we still access errno afterwards
    4. check!

  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




Felipe




   

   







  

 



 

  


   

   

    
 
Felipe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...