[Vortex] Email: Add configuration to send email as HTML

Review Request #1226 — Created Oct. 28, 2024 and submitted

Information
smillernl
Lunr.Vortex
feat/mail/set_html
Reviewers
lunr 
Email: Add configuration to send email as HTML
https://github.com/lunr-php/lunr.vortex/pull/8
  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
marcella.galambos
marcella.galambos 
  1. Ship It!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




b.stoop




   

   







  

 



 

  


   

   

    
 
b.stoop


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/Email/EmailPayload.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Why not is_html just like the property name?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Because is_html says nothing about what is HTML.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      What else could be html here than?
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      The title, the addresses, the communication protocol, the source, the... any input really.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      I'm not going into this. I just want to know why the method name is different than the property name?
      
 
      

      5. 



    5. 
 
 
      
 
      
  
 
      
 
      
  
      element key name*
      
 
      

      6. 



    6. 
 
 
      
 
      
  
 
      
 
      
  
      ah, so it's not about the property on the PHP mailer side. I guess I can change the element key to use body_as_html.
      
 
      

      7. 



    7. 
 
 
      
 
      
  
 
      
 
      
  
      That is fine for me
      
 
      

      8. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    You should update the comment
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Ditto
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 





 

  

   




b.stoop




   

   







  

 



 

  


   

   

    
 
b.stoop


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Missing the expects call to isHTML of the mail_transport
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




smillernl




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (41d9a51)





 


 










  

 









     

    

   

  

  

   
   Loading...