[Lunr.Gravity] SQLite3: Add support for RETURNING

Review Request #1223 — Created Sept. 6, 2024 and submitted Sept. 16, 2024, 11:16 a.m.

Information
Owner:	marcella.galambos
Repository:	Lunr.Gravity
Branch:	ML-925-add-support-for-delete-insert-replace-returning-for-sq-lite-3
Bugs:
Depends On:
Commit:	b42511c...
Reviewers
Groups:	lunr
People:

Description

[Lunr.Gravity] SQLite3: Add support for DELETE/INSERT/REPLACE ... RETURNING

Testing Done

https://github.com/lunr-php/lunr.gravity/pull/2

Issues

Description	From	Last Updated
The commit message should not include [Lunr.Gravity]	pprkut	Sept. 9, 2024, 1:10 p.m.
This is wrong already in the place you copied it from, but since this is new code... Technically this is ...	pprkut	Sept. 9, 2024, 1:10 p.m.
We can skip ->setAccessible() with newer PHP versions. It's a no-op now.	pprkut	Sept. 9, 2024, 1:10 p.m.

Show all issues

The commit message should not include [Lunr.Gravity]

src/Lunr/Gravity/SQLite3/Tests/SQLite3DMLQueryBuilderDeleteTest.php (Diff revision 1)

Show all issues

This is wrong already in the place you copied it from, but since this is new code...

Technically this is not related to Delete now that we have INSERT/REPLACE support it too ;)

src/Lunr/Gravity/SQLite3/Tests/SQLite3DMLQueryBuilderDeleteTest.php (Diff revision 1)
Show all issues
```
We can skip ->setAccessible() with newer PHP versions. It's a no-op now.
```

-	[Lunr.Gravity] SQLite3: Add support for RETURNING
+	SQLite3: Add support for RETURNING

~		SQLite3: Add support for DELETE/INSERT/REPLACE ... RETURNING
	~	[Lunr.Gravity] SQLite3: Add support for DELETE/INSERT/REPLACE ... RETURNING

-	5f939c7baa1dabadfccab2879a4856b95d360ce5
+	b42511c2bb5405d9af394a66cb184847b4b0dcab

	src/Lunr/Gravity/SQLite3/SQLite3DMLQueryBuilder.php
	src/Lunr/Gravity/SQLite3/Tests/SQLite3DMLQueryBuilderQueryTest.php

-	SQLite3: Add support for RETURNING
+	[Lunr.Gravity] SQLite3: Add support for RETURNING

Pushed to master (8311c0e)

Ship it!

You have a pending review.