[Locator] PHPStan: Add get method to ignore containerinterface get calls inside locator files

Review Request #1199 — Created July 29, 2024 and submitted

Information
b.stoop
Lunr.Locator
phpstan/get
f90a5b3...
Reviewers
lunr 
Based on release/0.9.x


PHPStan: Add get method to ignore containerinterface get calls inside locator files
https://github.com/lunr-php/lunr.locator/pull/10
  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
b.stoop
smillernl
smillernl 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Why?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I'll revert this change, its my IDE which sorts the imports in alphabetical order
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I'm fine with that rule by the way, I would just like it to be documented somewhere (and maybe enforced).
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      https://github.com/slevomat/coding-standard/blob/master/doc/namespaces.md#slevomatcodingstandardnamespacesalphabeticallysorteduses-
      

      In order to enforce it, we'd need to add a git submodule for the slevomat standard (which we planned to do anyway) and enable that particular sniff. (and fix it everywhere first)
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Leaving this in the review will be in step closer to fixing it everywhere (;
      
 
      

      5. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




b.stoop




   

   







  

 



 

  


   

   

    
 
b.stoop


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Tested it again and its probably not necessary (:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




smillernl




   

   







  

 



 

  


   

   

    
 
smillernl


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release/0.9.x (7f050e3)





 


 










  

 









     

    

   

  

  

   
   Loading...