[Vortex] FCM: Allow to send to topics and conditions

Review Request #1194 — Created July 12, 2024 and submitted

Information
b.stoop
Lunr.Vortex
fcm/sendtopics
106df69...
Reviewers
lunr 
Based on release/0.9.x


FCM: Allow to send to topics and conditions
https://github.com/lunr-php/lunr.vortex/pull/6
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
pprkut
pprkut 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/FCM/FCMPayload.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    The payload changes are less controversial than the dispatcher changes. If you split them out, we can merge them quicker.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      You left no comment for the dispatches changes, so I asume that that is mergable then ;)
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/FCM/FCMPayload.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    The typical way of handling such conflicts is: last one counts. So IMHO, rather than throwing exceptions, I'd just unset the other ones.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I see your point, I think we should a warning or debug message once we set a different target.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      IMHO just adding it to the documentation is good enough
      
 
      

      3. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release/0.9.x (106df69)





 


 










  

 









     

    

   

  

  

   
   Loading...