Summary: |
|
||||
|---|---|---|---|---|---|
Depends On: |
|
[Vortex] FCM: Add analytics hooks for Requests `request_multiple`
Review Request #1136 — Created April 18, 2024 and discarded
| Information | |
|---|---|
| b.stoop | |
| Lunr.Vortex | |
| fcmbatch/analytics | |
|
|
|
| Reviewers | |
| lunr | |
Based on master
The requests library lacks the hooks we need for the analytics that why I implemented them here.
https://github.com/WordPress/Requests/blob/develop/docs/hooks.mdFCM: Add analytics hooks for Requests `request_multiple`
github actions: https://github.com/brianstoop/lunr.vortex/actions/runs/8738095255
- 1
- 0
- 0
- 0
- 1
| Description | From | Last Updated |
|---|---|---|
| Sorry, no. The purpose of the Requests-Hooks plugin is that we don't need to add special code on every call ... |
pprkut
|
-
-
src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1) Sorry, no. The purpose of the Requests-Hooks plugin is that we don't need to add special code on every call site. If you need this, it means features are missing from Requests directly.
-
-
src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1) The docs mention that you should do this, but I couldn't find a reason why...