pprkut
-
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSPushNotificationStatusTrait.php (Diff revision 1) Please don't make this a trait, or provide a very good reason why it has to be one.
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSPushNotificationStatusTrait.php (Diff revision 1) We're not going to reuse APNS errors in the FCM code. It's just not going to happen.
If there is code to be shared here it would have to be generalized. But then you also need to account for both APNS and FCM having additional statuses that the other one doesn't have.
[Vortex] APNS: Split out apns response status mapping
Review Request #1102 — Created Jan. 18, 2024 and discarded
| Information | |
|---|---|
| b.stoop | |
| Lunr.Vortex | |
| apns/responsestatus | |
| 1090 | |
| Reviewers | |
| lunr | |
Based on master
APNS: Split out apns response status mapping
Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/7569365389
