pprkut
smillernl
Change Summary:
Rebased on master
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||
Commit: |
|
||||||||||||||||||
Diff: |
Revision 2 (+489 -557) |
[Vortex] FCM: Update response class for the new firebase v1 API
Review Request #1090 — Created Jan. 11, 2024 and submitted
| Information | |
|---|---|
| b.stoop | |
| Lunr.Vortex | |
| fcm/updateresponse | |
|
|
|
| 1126 | |
| 62cd815... | |
| Reviewers | |
| lunr | |
Based on master
FCM: Update response class for the new firebase v1 API
The response changed as well, see the response json files in the diff. Referenced: https://firebase.google.com/docs/reference/fcm/rest/v1/FcmError. This probably needs some testing and tweaking once we have more responses from firebase as the documentation is not very clear or even inconsistent
Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8068348457
-
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSPushNotificationStatusTrait.php (Diff revision 2) What does this have to do with FCM?
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Depends On: |
|
||||||
Commit: |
|
||||||
Diff: |
Revision 3 (+419 -520) |
-
-
src/Lunr/Vortex/FCM/FCMResponse.php (Diff revision 3) Similar to the payloads. If we need platform specific response handling, since we have platform specific payloads already, we can platform specific responses for
fcm-android,fcm-apnsandfcm-webpushtoo.There should still be a way to handle responses for mixed payload, so subclassing is probably not the solution to look for here, but something that splits up the code into separate components more.
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 4 (+354 -512) |
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 5 (+354 -512) |