[Vortex] FCM: Remove batch implementation for fcm notifications

Review Request #1085 — Created Dec. 29, 2023 and submitted

Information
b.stoop
Lunr.Vortex
fcm/removebatch
1088
1c5959f...
Reviewers
lunr 
Based on master


FCM: Remove batch implementation for fcm notifications


For the new firebase API v1 we cannot send notifications in batches anymore so we need to remove the batch implementation
Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/7540408777
  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
pprkut
pprkut 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    

    For the new firebase API v1 we cannot send notifications in batches anymore so we need to remove the batch implementation

    

    

    I'm afraid, this is not correct. The new API does no longer support sending to multiple endpoints with one API call, but we still want to support batching.
    

    If we remove the batch support, the dispatcher will see that we don't support the PushNotificationMultiDispatcherInterface and send the endpoint one by one.
    

    But in order to make use of curl multi requests, we need to get endpoints in batches.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yes that is correct, but before we implement a new batching method we need to sent the requests one by one or it won't work with the new API. I think this is the easiest way to (temp) remove the batching and migrate to the new API before we implement a new batching method.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Did we remove the batching for APNS too? I think we're just looping there.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      For APNS the batching is handled in the APNSPHP library
      
 
      

      4. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should be based on master, not release/0.8.x
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 















 



 

  

   




b.stoop




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (5414fe1)





 


 










  

 









     

    

   

  

  

   
   Loading...