-
-
src/Lunr/Corona/Exceptions/DataHttpException.php (Diff revision 1) I don't like the name, the rest is all good. Can you come up with something better? :D
[Corona] Move data for exception responses to seperate base exception
Review Request #1073 — Created Nov. 17, 2023 and submitted
Information | |
---|---|
b.stoop | |
Lunr | |
exceptions/datahttpexception | |
1293319... | |
Reviewers | |
lunr | |
Based on release/0.8.x
Corona: Move data for exception responses to seperate base exception
GitHub actions runs:
PHP Tests: https://github.com/brianstoop/lunr/actions/runs/6942364683
General Tests: https://github.com/brianstoop/lunr/actions/runs/6942364684
-
-
src/Lunr/Corona/Exceptions/DataHttpException.php (Diff revision 1) Make it
abstract
, if possible, to indicate this isn't supposed to be used directly.
Testing Done: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 2 (+566 -182) |