[Corona] Move data for exception responses to seperate base exception

Review Request #1073 — Created Nov. 17, 2023 and submitted

b.stoop
Lunr
exceptions/datahttpexception
1293319...
lunr

Based on release/0.8.x

Corona: Move data for exception responses to seperate base exception

GitHub actions runs:
PHP Tests: https://github.com/brianstoop/lunr/actions/runs/6942364683
General Tests: https://github.com/brianstoop/lunr/actions/runs/6942364684

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
pprkut
  1. 
      
  2. src/Lunr/Corona/Exceptions/DataHttpException.php (Diff revision 1)
     
     
     
     
     

    I don't like the name, the rest is all good. Can you come up with something better? :D

    1. How about ClientDataException?

    2. Seems better to me :)

  3. 
      
pprkut
  1. 
      
  2. src/Lunr/Corona/Exceptions/DataHttpException.php (Diff revision 1)
     
     
     
     
     

    Make it abstract, if possible, to indicate this isn't supposed to be used directly.

  3. 
      
b.stoop
smillernl
  1. Ship It!
  2. 
      
b.stoop
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release/0.8.x (8a7cf2a)
Loading...